Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue9fix #15

Merged
merged 3 commits into from
Jul 28, 2018
Merged

Issue9fix #15

merged 3 commits into from
Jul 28, 2018

Conversation

iirzyk
Copy link
Contributor

@iirzyk iirzyk commented Jul 28, 2018

Added fix to issuse when working in optimized mode and using scripts compiled from scratch - path to the script_executable changed to default value: path + built/optimized/scratch + script_name .

@DvdMgr DvdMgr changed the base branch from master to gsoc-week11 July 28, 2018 08:04
@DvdMgr
Copy link
Member

DvdMgr commented Jul 28, 2018

Thanks for the pull request!

I noticed that the commits only seem to involve optimized mode: does the issue present itself in optimized mode only, or is it also present in debug builds? In case it's the latter, we may need to add some code to support that case, too.

I also noticed that tests for this feature are missing - if you need some guidance on writing and running tests, let me know and we can work on this together! Alternatively, I can add them directly to this pull request.

@iirzyk
Copy link
Contributor Author

iirzyk commented Jul 28, 2018

Yes this issue presented itself only in optimized mode, I never really wrote any test so i don't really know how to proceed with them. If you want you can add them directly to this pull request.

@codecov
Copy link

codecov bot commented Jul 28, 2018

Codecov Report

Merging #15 into gsoc-week11 will increase coverage by 0.01%.
The diff coverage is 100%.

Impacted file tree graph

@@              Coverage Diff               @@
##           gsoc-week11     #15      +/-   ##
==============================================
+ Coverage        96.19%   96.2%   +0.01%     
==============================================
  Files                7       7              
  Lines              525     527       +2     
  Branches           120     121       +1     
==============================================
+ Hits               505     507       +2     
  Misses              11      11              
  Partials             9       9
Impacted Files Coverage Δ
sem/runner.py 89.69% <100%> (+0.21%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 01a04f9...5654e2e. Read the comment docs.

@DvdMgr DvdMgr merged commit 96f0767 into signetlabdei:gsoc-week11 Jul 28, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants