-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introduce support for CMake-based ns-3 versions and fix tests #62
Conversation
Copy ns-3 folder in the example subdir DO not copy cmake-cache, as it is directory-dependant
…/sem into new-buildsystem-fix
Massive work, @pagmatt. Shouldn't |
Thanks @MatteoDrago! |
Makes totally sense. As a matter of fact, the doc should be updated as well in some points... But that's for another PR, I agree! Thanks! |
This PR completes the support for the newer,
CMake
-based versions of ns-3.The main changes are:
Document
fromtinydb.table
has been added incli.py
configure_and_build
function, do not redirect to PIPE stderr when callingsubprocess.Popen ()
.When compiling, you can now get a mix of stdout and stderr output when compilation errors and/or warnings arise. This was causing a race condition between
stdout.readline ()
andsubprocess.poll ()
which causedget_build_output
to never return.It is actually suggested to use
subprocess.communicate ()
as a safer alternative; however, this would not allow us to retrieve the compilation progress. Thus, the proposed solution of missing out on stderr, while at least capturing stdout.--enable-modules=core
flag when configuring ns-3 during the tests. Since only such module is needed, this was an obvious choice as it significantly reduces testing time./usr/share/dict/web2
and/usr/share/dict/web2a
as input parameters to/usr/share/dict/american-english
and/usr/share/dict/british-english
. The previous dictionaries are not installed by default on recent Ubuntu distributions.