Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(config): add chiado bootnodes ENRs #4727

Merged
merged 2 commits into from
Feb 1, 2024

Conversation

4rgon4ut
Copy link
Contributor

@4rgon4ut 4rgon4ut commented Sep 12, 2023

Issue Addressed

PR introduce post-review fix in Chiado bootnodes ENRs list.

Canonical bootnodes can be found here https://github.com/gnosischain/configs/blob/main/chiado/bootnodes.yaml

Proposed Changes

Added 4 ENRs.

Additional Info

Those ENRs were removed due invalid padding.
Context: #4530 (comment)

All ENRs now valid and decoded well on my end.

@CLAassistant
Copy link

CLAassistant commented Sep 12, 2023

CLA assistant check
All committers have signed the CLA.

@jimmygchen jimmygchen added the ready-for-review The code is ready for review label Oct 18, 2023
Copy link
Collaborator

@dapplion dapplion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have ensured that the bootnodes match the canonical file at https://github.com/gnosischain/configs/blob/main/chiado/bootnodes.yaml

@AgeManning AgeManning added ready-for-merge This PR is ready to merge. and removed ready-for-review The code is ready for review labels Jan 31, 2024
@AgeManning
Copy link
Member

@Mergifyio queue

Copy link

mergify bot commented Jan 31, 2024

queue

🟠 The pull request is the 1st in the queue to be merged

#4727 is queued for merge.

Required conditions of queue default for merge:

  • check-success=local-testnet-success
  • check-success=test-suite-success

Required conditions to stay in the queue:

  • -draft [📌 queue requirement]
  • any of: [📌 queue -> configuration change requirements]
    • -mergify-configuration-changed
    • check-success=Configuration changed
  • any of: [🔀 queue conditions]
    • all of: [📌 queue conditions of queue default]
      • #approved-reviews-by >= 1
      • check-success=license/cla
      • check-success=target-branch-check

Visit the Mergify Dashboard to check the state of the queue default.

@michaelsproul michaelsproul changed the title feat(config): add chiado bootnodes erns feat(config): add chiado bootnodes ENRs Feb 1, 2024
@michaelsproul
Copy link
Member

@Mergifyio queue

Copy link

mergify bot commented Feb 1, 2024

queue

✅ The pull request has been merged automatically

The pull request has been merged automatically at b7ba5a0

mergify bot added a commit that referenced this pull request Feb 1, 2024
@mergify mergify bot merged commit b7ba5a0 into sigp:unstable Feb 1, 2024
28 of 29 checks passed
@4rgon4ut 4rgon4ut deleted the feat/add-chiado-bootnodes branch February 8, 2024 12:07
danielramirezch pushed a commit to danielramirezch/lighthouse that referenced this pull request Feb 14, 2024
* feat(config): add chiado bootnodes erns

* Merge remote-tracking branch 'origin/unstable' into feat/add-chiado-bootnodes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-for-merge This PR is ready to merge.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants