Config for web3signer keep-alive #5007
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michaelsproul
added
bug
michaelsproul
force-pushed
the
web3signer-keep-alive
branch
from
3f45967
to
9006974
Compare
|
Although there may be better approaches than these flags, we have one Lido operator reporting success with these flags on Holesky, to the point where they are requesting custom builds of Lighthouse release that include this change. I think we may as well include this in The flag they are using is |
michaelsproul
added
ready-for-review
michaelsproul
changed the title
realbigsean
added
ready-for-merge
|
@Mergifyio queue |
✅ The pull request has been merged automaticallyThe pull request has been merged automatically at 8fb6989 |
This was referenced Feb 1, 2024
danielramirezch
pushed a commit
to danielramirezch/lighthouse
that referenced
this pull request
Feb 14, 2024
* Allow tweaking connection pool settings * Build docker image * Fix imports * Merge tag 'v4.6.0' into web3signer-keep-alive v4.6.0 * Delete temp docker build stuff * Fix tests * Merge remote-tracking branch 'origin/unstable' into web3signer-keep-alive * Update CLI text
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue Addressed
Addresses #4439 in the context of web3signer connections.
One of the large staking pools was having issues with web3signer connections failing with
IncompleteMessageerrors.Proposed Changes
Additional Info
I'm not sure if this is the best way to solve this. Requiring the node operator to fiddle with yet more CLI flags is bad from a UX PoV. We may be better off adopting automatic retry.