-
Notifications
You must be signed in to change notification settings - Fork 547
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate documentation to docs.sigstore.dev #822
Comments
Happy to help with this! Which content should be migrated? Everything from the |
Thanks @endorama , /doc is just auto generated stuff , most of its in the .md files in the root (including the main README.md) |
+1, we should figure out a migration plan and cutoff to get everything into the other site. |
I was going through the docs for the website, do I need an invite to Netlify CMS? At the moment I would start migrating pages and writing a script to synchronize them between cosign and website repositories. This would allow to have the content on the website quickly with an easy path for manual updates. What is the expected flow once the migration is finished? Will cosign docs still be in this repo or every contribution must/will happen in website repo? |
Already made a start on this (in fact it should be good to go) |
Nice! Now we have to figure out how to best link over to those docs from here, and what should stay here. Maybe this readme can contain installation instructions, a quickstart, and then a link to the full docs on the website? |
One other quick thing I noticed when browsing those docs: we should probably leave the specification files here in this repo: https://docs.sigstore.dev/cosign/cosign_predicate_spec |
@dlorenc do you think is better to just link to the |
Yeah - linking to here would be best I think. |
Just going through all the GFI's and found this one is the oldest, thought I'd offer my help to get it across the line :) - providing there's anything left to do @dlorenc @endorama @lukehinds ? |
We should increase the number of examples in docs.sigstore.dev, we have lots of examples for container signing but not many for blob signing. https://github.com/sigstore/cosign/blob/main/KMS.md should be brought over to the docs. Lots of documentation will need to be updated as part of #2534 also. https://github.com/sigstore/cosign/tree/main/specs should be cleaned up and added. |
Thanks so much @ChrisJBurns ! +1 to migrating lots of KMS.md along with README.md, EXAMPLES.md, KEYLESS.md, and IMPORT.md. We can leave a few simple README.md examples in, with a pointer back to docs.sigstore.dev.
Agreed but I think because that's tracked separately it doesn't need to be addressed as part of this issue.
IMO we should leave that in this repo. (We deliberately pulled it out in sigstore/sigstore-website#74) |
Thanks @znewman01 although not sure if I'm looking in the right place? The file paths in the Am I correct in assuming that we use There's also a couple of things that I'm getting mixed up by, mainly that (I believe) this PR is to port the docs from this repo into the So am a bit confused atm, are we porting over the docs from this repo into the |
The documentation repo is now https://github.com/sigstore/docs (sigstore/sigstore-website is the frontend "Marketing" site for Sigstore) The Cosign documentation is in I'm happy to collaborate on bringing more things over. There are a few known URL issues on the docs site, and I have a PR open to address those |
Thank you @ltagliaferri I'm going to start with the |
TYVM @ChrisJBurns ! I'll warn you right now: you may have to be a little patient because we may say "oh leave that in README.md" a bunch 😄 If you start with adding things to the docs before we copy them from Cosign (feel free to CC me in, I don't usually get docs repo notifications) that'll probably be safer. |
@znewman01 Shall do 👍 What I can do is put a |
Just a note should be fine! Will review your PR shortly, I'm unburying myself from a week's holiday right now :) |
sigstore/docs#123 will see to the last non Also would we know what would be required to close this ticket? Are there a list of docs pages we want to migrate over, or have we done the majority of them? I ask because there are also the following:
Would we want to migrate those also? |
I would prefer we don't migrate anything in the README over. At a glance, everything appears to be covered in documentation or is outdated. Out of what's listed, USAGE is likely redundant, so I don't think it needs to be moved. The other three might fit somewhere, but it'd be good to confirm if they are redundant. |
@haydentherapper Yep agreed on the |
@lukehinds @znewman01 @haydentherapper @dlorenc @ltagliaferri @endorama So I think we should be able to consider closing this ticket as of now. The following docs have been migrated from cosign into the relevant docs pages and are all available on the https://docs.sigstore.dev/.
A deprecation note has been added to all of the above mentioned cosign doc pages and can be removed whenever you're ready. This should stop folks from adding more content to the pages and instead will redirect them to the official docs repository. I haven't touched the Example:
Would become:
There's only a couple of instances of this, so I'm nitpicking at this point 😄 I'm more than happy to do the |
@ChrisJBurns Why am I tagged in this? |
@znewman I think he meant me :) |
@znewman Apologies, I meant @znewman01, I got a bit trigger happy with the send button 😢 |
Happy to close it out for now! Thanks for the hard work here @ChrisJBurns |
Cosign documentation was migrated to https://docs.sigstore.dev/ in sigstore/cosign#822 and the markdown files were removed in sigstore/cosign#3587. Tetragon documentation was linking to one of this files. Now it's linking to https://docs.sigstore.dev/. While here, remove `COSIGN_EXPERIMENTAL=1` from the cosign command for verifying keyless-signed images. It's not required since cosign v2.0.0 (see https://blog.sigstore.dev/cosign-2-0-released/). Signed-off-by: Anna Kapuscinska <anna@isovalent.com>
Cosign documentation was migrated to https://docs.sigstore.dev/ in sigstore/cosign#822 and the markdown files were removed in sigstore/cosign#3587. Tetragon documentation was linking to one of this files. Now it's linking to https://docs.sigstore.dev/. While here, remove `COSIGN_EXPERIMENTAL=1` from the cosign command for verifying keyless-signed images. It's not required since cosign v2.0.0 (see https://blog.sigstore.dev/cosign-2-0-released/). Signed-off-by: Anna Kapuscinska <anna@isovalent.com>
We now have a nice docs site, so let's start moving content into there.
Seeking volunteers to help with this and also add more content.
The text was updated successfully, but these errors were encountered: