Included timeout option for uploading to Rekor

[naveensrinivasan]

Included a timeout option to sign-blob because uploading a large binary to rekor was failing with timeout.

#990

[lukehinds]

Not sure I understand the logic here. rekor will timeout regardless of a client timing out, whereas with the client having a timeout you will never know the server has timed out in the first place. I would have thought it more useful for the client to know there has been timeout (and then take action accordingly), rather then bail early under the pretence there may timeout?

[naveensrinivasan]

Not sure I understand the logic here. rekor will timeout regardless of a client timing out, whereas with the client having a timeout you will never know the server has timed out in the first place. I would have thought it more useful for the client to know there has been timeout (and then take action accordingly), rather then bail early under the pretence there may timeout?

Makes sense, but the default client timeout is only 30 seconds https://github.com/sigstore/rekor/blob/5bf082ac60f873cee7e6de8a97142907ee0134e7/pkg/generated/client/entries/create_log_entry_parameters.go#L45 and I was following the logic of rekor to increase the timeout https://github.com/sigstore/rekor/blob/5bf082ac60f873cee7e6de8a97142907ee0134e7/cmd/rekor-cli/app/upload.go#L82.

I was able to test the uploads with increase timeout and it did work on a larger blob

What if we include this timeout and also validate with max of what the rekor is? What do your thoughts?

[lukehinds]

interesting, I never knew we had rekor client timeouts.

in regards to your proposal I am not of strong view here, so can let others chime in. There is no harm in having a timeout flag, I guess as long as users don't believe it will have influence on the servers timeout rules.