remove Verify in favor of explicit VerifyImage{Signatures, Attestations}
#1026
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattmoor
reviewed
Nov 10, 2021
pkg/cosign/verify.go
Outdated
| // Find the uuid then the entry. | ||
| uuid, _, err := FindTlogEntry(rekorClient, b64sig, payload, pemBytes) | ||
| if err != nil { | ||
| if err := verifyBase64Signature(ctx, verifier, b64sig, payload); err != nil { |
There was a problem hiding this comment.
Rather than passing b64sig, which we know to be "" call this verifyAttestation, push the newReverseDSSEVerifier wrapper into this call, and have this take the signature.
dekkagaijin
force-pushed
the
verify
branch
2 times, most recently
from
ae0c914
to
320bdf9
Compare
…tions}` Signed-off-by: Jake Sanders <jsand@google.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a first pass to begin disentangling and refactoring our verification flow to make it more usable, plugable, and extensible. Behavior should remain unchanged.
Starts addressing #844 and #931