This sets up the scaffolding for the cosigned CRD types.
#1504
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattmoor
force-pushed
the
clusterimagepolicy-scaffolding
branch
from
1ebda94
to
2420595
Compare
|
cc @kkavitha @coyote240 @hectorj2f I'll get this passing CI, but this should set up all of the scaffolding that you need. |
mattmoor
force-pushed
the
clusterimagepolicy-scaffolding
branch
from
2420595
to
bcbb09e
Compare
|
Ultimately, this is the spec for what this CRD will look like in subsequent changes: https://docs.google.com/document/d/1gBLEOOHWOmvHVsoJbgGU74GdwA6CGxMRp3MAeEB50l4/edit |
mattmoor
force-pushed
the
clusterimagepolicy-scaffolding
branch
9 times, most recently
from
48b437d
to
b3d5e5e
Compare
mattmoor
force-pushed
the
clusterimagepolicy-scaffolding
branch
from
b3d5e5e
to
eedb826
Compare
|
It verified!!! |
mattmoor
force-pushed
the
clusterimagepolicy-scaffolding
branch
from
eedb826
to
1ea1ebb
Compare
|
@dlorenc yeah, because |
mattmoor
force-pushed
the
clusterimagepolicy-scaffolding
branch
from
1ea1ebb
to
b5a6ee2
Compare
This mostly contains the boilerplate stuff like codegen and whatnot to bootstrap a Knative controller. This doesn't contain any of the meaningful type definition aspects, which will follow in a subsequent PR. Sets up for sigstore#1417 Signed-off-by: Matt Moore <mattmoor@chainguard.dev>
mattmoor
force-pushed
the
clusterimagepolicy-scaffolding
branch
from
b5a6ee2
to
5ae39f3
Compare
mattmoor
commented
Feb 23, 2022
|
|
||
| // ClusterImagePolicySpec holds the desired state of the ClusterImagePolicy (from the client). | ||
| type ClusterImagePolicySpec struct { | ||
| // TODO(#1417): Flesh out the specification from the API spec. |
There was a problem hiding this comment.
This, a body for SetDefaults and Validate and unit tests are the key bits remaining to close this issue out.
I believe your WIP schema should slot in pretty directly here.
Once this lands, I'm happy to set up the webhook and CRD definition stuff while you sketch the type out, but was aiming for an MVP here to unblock y'all.
hatmarch
pushed a commit
to hatmarch/cosign
that referenced
this pull request
Apr 19, 2022
…1504) This mostly contains the boilerplate stuff like codegen and whatnot to bootstrap a Knative controller. This doesn't contain any of the meaningful type definition aspects, which will follow in a subsequent PR. Sets up for sigstore#1417 Signed-off-by: Matt Moore <mattmoor@chainguard.dev>
mlieberman85
pushed a commit
to mlieberman85/cosign
that referenced
this pull request
May 6, 2022
…1504) This mostly contains the boilerplate stuff like codegen and whatnot to bootstrap a Knative controller. This doesn't contain any of the meaningful type definition aspects, which will follow in a subsequent PR. Sets up for sigstore#1417 Signed-off-by: Matt Moore <mattmoor@chainguard.dev>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This mostly contains the boilerplate stuff like codegen and whatnot to bootstrap a Knative controller. This doesn't contain any of the meaningful type definition aspects, which will follow in a subsequent PR.
Signed-off-by: Matt Moore mattmoor@chainguard.dev
Ticket Link
Sets up for #1417
Release Note