Fix #1583 #1582. Disallow regex now until implemented. #1584
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ville Aikas <vaikas@chainguard.dev>
Codecov Report
@@ Coverage Diff @@
## main #1584 +/- ##
==========================================
+ Coverage 27.19% 27.46% +0.27%
==========================================
Files 136 137 +1
Lines 7712 7741 +29
==========================================
+ Hits 2097 2126 +29
Misses 5386 5386
Partials 229 229
Continue to review full report at Codecov.
|
mattmoor
approved these changes
Mar 10, 2022
Comment on lines
+22
to
+24
| // to find, since they handle '*' anywhere in the string as a wildcard. For our | ||
| // use we only want to handle it at the end, and hence this effectively turns | ||
| // into 'hasPrefix' string matching up to the trailing *. |
There was a problem hiding this comment.
I think we want to handle it in a bunch of places as well, e.g. to glob out the account number of region in an ECR repo.
One other thing we will need to consider is normalizing image names, e.g. ubuntu vs. docker.io/ubuntu vs. docker.io/ubuntu:latest`.
There was a problem hiding this comment.
This is fine for now, but I think we should plan to expand this in subsequent changes.
mlieberman85
pushed a commit
to mlieberman85/cosign
that referenced
this pull request
May 6, 2022
sigstore#1584) Signed-off-by: Ville Aikas <vaikas@chainguard.dev>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Ville Aikas vaikas@chainguard.dev
Summary
Implement glob support for ClusterImagePolicy. Supports trailing '*' only. Fixes #1582
Disallow regex until there's actually support for implementing it.
Fix incorrect error message fields. #1583
Ticket Link
Fixes: #1582
Fixed: #1583
Release Note