Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change file_name_template to PackageName #1683

Merged
merged 1 commit into from
Mar 30, 2022
Merged

Conversation

strongjz
Copy link
Contributor

Signed-off-by: James Strong strong.james.e@gmail.com

Summary

Change NFPM artifacts names to match package_name

Ticket Link

Fixes #1643

Release Note

Update Change NFPM artifacts names to match package_name, ie `cosign` and not `cosign-linux-amd64`

Signed-off-by: James Strong <strong.james.e@gmail.com>
@codecov-commenter
Copy link

codecov-commenter commented Mar 30, 2022

Codecov Report

Merging #1683 (f3000c9) into main (2fcf30e) will increase coverage by 1.27%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #1683      +/-   ##
==========================================
+ Coverage   27.97%   29.25%   +1.27%     
==========================================
  Files         137      140       +3     
  Lines        7820     8370     +550     
==========================================
+ Hits         2188     2449     +261     
- Misses       5403     5654     +251     
- Partials      229      267      +38     
Impacted Files Coverage Δ
pkg/cosign/kubernetes/webhook/validator.go 81.75% <0.00%> (-1.80%) ⬇️
cmd/cosign/cli/verify/verify_blob.go 10.63% <0.00%> (-1.36%) ⬇️
pkg/apis/config/image_policies.go 69.38% <0.00%> (-1.35%) ⬇️
pkg/cosign/tuf/client.go 62.34% <0.00%> (-0.95%) ⬇️
pkg/cosign/fetch.go 0.00% <0.00%> (ø)
pkg/cosign/common.go 0.00% <0.00%> (ø)
cmd/cosign/cli/sign.go 0.00% <0.00%> (ø)
cmd/cosign/cli/clean.go 0.00% <0.00%> (ø)
cmd/cosign/cli/attest.go 0.00% <0.00%> (ø)
cmd/cosign/cli/verify.go 0.00% <0.00%> (ø)
... and 18 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2fcf30e...f3000c9. Read the comment docs.

@dlorenc dlorenc merged commit b848df7 into sigstore:main Mar 30, 2022
@github-actions github-actions bot added this to the v1.7.0 milestone Mar 30, 2022
mlieberman85 pushed a commit to mlieberman85/cosign that referenced this pull request May 6, 2022
Signed-off-by: James Strong <strong.james.e@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Binary for Debian release has unexpected name
3 participants