Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update release job #1720

Merged
merged 4 commits into from
Apr 7, 2022
Merged

Update release job #1720

merged 4 commits into from
Apr 7, 2022

Conversation

cpanato
Copy link
Member

@cpanato cpanato commented Apr 7, 2022

Summary

  • update cosign image to v1.7.1
  • put the linux-pivkey-pkcs11key-amd64 binary in the dist root and not in its own directory, similar to others
  • add back the gcr>ghcr copy but if that step fail do not fail the entire build

I will do a rehearsal later this week

Ticket Link

n/a

Release Note

NONE

…4 binary to the dist root

Signed-off-by: cpanato <ctadeu@gmail.com>
Signed-off-by: cpanato <ctadeu@gmail.com>
…e build

Signed-off-by: cpanato <ctadeu@gmail.com>
Signed-off-by: cpanato <ctadeu@gmail.com>
Copy link
Contributor

@hectorj2f hectorj2f left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@dlorenc dlorenc merged commit 460ad52 into sigstore:main Apr 7, 2022
@github-actions github-actions bot added this to the v1.8.0 milestone Apr 7, 2022
@cpanato cpanato deleted the update-release branch April 8, 2022 07:31
mlieberman85 pushed a commit to mlieberman85/cosign that referenced this pull request May 6, 2022
* enable push to github release and set the linux-pivkey-pkcs11key-amd64 binary to the dist root

Signed-off-by: cpanato <ctadeu@gmail.com>

* update cosign to v1.7.1

Signed-off-by: cpanato <ctadeu@gmail.com>

* enable back gcr to ghcr copy but if that fail does not fail the entire build

Signed-off-by: cpanato <ctadeu@gmail.com>

* remove debug flag

Signed-off-by: cpanato <ctadeu@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants