chore: add warning when attaching sBOMs #1756
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: hectorj2f <hectorf@vmware.com>
hectorj2f
changed the title
hectorj2f
changed the title
|
Should we do this on download as well? cc @vaikas |
vaikas
approved these changes
Apr 14, 2022
There was a problem hiding this comment.
Might as well at least print the message on download that it has not been signed, but we can do that in a followup.
Thanks for doing this @hectorj2f
|
@vaikas i will add a new commit for this PR. Thanks guys |
mlieberman85
pushed a commit
to mlieberman85/cosign
that referenced
this pull request
May 6, 2022
Signed-off-by: hectorj2f <hectorf@vmware.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: hectorj2f hectorf@vmware.com
Summary
This PR adds a warning to users when attaching sBOMs.In order to ensure tamper-proof sBOMs and validate its authenticity,
sigstorerecommends to sign them or include them in an in-toto attestation as part of the predicate.Related to this RFC ##1742
Ticket Link
Fixes
Release Note