add clean sub-command for deleting signature metadata from a given image #324
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is awesome! It looks like you're missing some license boilerplate, and I had one nit on the help text as a suggestion. A test similar to this one would be awesome too: https://github.com/sigstore/cosign/blob/main/test/e2e_test.go#L63 You can sign an image, make sure it verifies, then clean, then make sure it doesn't verify. Let me know if that makes sense! |
dlorenc
reviewed
May 14, 2021
cmd/cosign/cli/clean.go
Outdated
| return &ffcli.Command{ | ||
| Name: "clean", | ||
| ShortUsage: "cosign clean <image uri>", | ||
| ShortHelp: "Clean the sign metadata from an image", |
There was a problem hiding this comment.
Suggested change
| ShortHelp: "Clean the sign metadata from an image", | |
| ShortHelp: "Remove all signatures from an image", |
Maybe this is more clear?
Signed-off-by: Batuhan Apaydın <batuhan.apaydin@trendyol.com>
dlorenc
approved these changes
May 14, 2021
|
Thanks @developer-guy ! |
dekkagaijin
referenced
this pull request
in dekkagaijin/cosign
May 17, 2021
Signed-off-by: Batuhan Apaydın <batuhan.apaydin@trendyol.com>
dekkagaijin
pushed a commit
that referenced
this pull request
May 17, 2021
Signed-off-by: Batuhan Apaydın <batuhan.apaydin@trendyol.com>
dekkagaijin
referenced
this pull request
in dekkagaijin/cosign
May 17, 2021
Signed-off-by: Batuhan Apaydın <batuhan.apaydin@trendyol.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Batuhan Apaydın batuhan.apaydin@trendyol.com