Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update builder image, cosign image, golangci-lint #3565

Merged
merged 4 commits into from
Mar 3, 2024

Conversation

cpanato
Copy link
Member

@cpanato cpanato commented Feb 29, 2024

Summary

  • Update builder image, cosign image, golangci-lint

Signed-off-by: cpanato <ctadeu@gmail.com>
Signed-off-by: cpanato <ctadeu@gmail.com>
Signed-off-by: cpanato <ctadeu@gmail.com>
Copy link

codecov bot commented Feb 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 40.44%. Comparing base (2ef6022) to head (dca34c0).
Report is 30 commits behind head on main.

❗ Current head dca34c0 differs from pull request most recent head b8a04c7. Consider uploading reports for the commit b8a04c7 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3565      +/-   ##
==========================================
+ Coverage   40.10%   40.44%   +0.34%     
==========================================
  Files         155      155              
  Lines       10044    10047       +3     
==========================================
+ Hits         4028     4064      +36     
+ Misses       5530     5494      -36     
- Partials      486      489       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@haydentherapper
Copy link
Contributor

Can you check out the lint failures?

Signed-off-by: cpanato <ctadeu@gmail.com>
@cpanato cpanato merged commit 7a2d50b into sigstore:main Mar 3, 2024
29 checks passed
@cpanato cpanato deleted the update-go branch March 3, 2024 22:33
@github-actions github-actions bot added this to the v2.3.0 milestone Mar 3, 2024
tommyd450 pushed a commit to tommyd450/cosign that referenced this pull request Jun 7, 2024
* update cosign and builder image

Signed-off-by: cpanato <ctadeu@gmail.com>

* update golangci-lint to v1.56

Signed-off-by: cpanato <ctadeu@gmail.com>

* update go.mod in fakeoidc

Signed-off-by: cpanato <ctadeu@gmail.com>

* fix lints

Signed-off-by: cpanato <ctadeu@gmail.com>

---------

Signed-off-by: cpanato <ctadeu@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants