Have the keyless cosign sign flow use a single 3LO.
#665
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With this change, the keyless flow builds a single signer for all of the images, which means a single key and 3LO for all of the references we sign: ```shell $ COSIGN_EXPERIMENTAL=true cosign sign ghcr.io/mattmoor/controller ghcr.io/mattmoor/webhook Generating ephemeral keys... Retrieving signed certificate... Your browser will now be opened to: https://oauth2.sigstore.dev/auth/auth?REDACTED Successfully verified SCT... tlog entry created with index: 693418 Pushing signature to: ghcr.io/mattmoor/controller:sha256-b10f4b2e04cde2e799e080068f162ef668c4db3099382798b5fe1a208023105d.sig tlog entry created with index: 693420 Pushing signature to: ghcr.io/mattmoor/webhook:sha256-ed1b1c778685ae0739cd4c6354fa2d724351b01e998a019d1ddc2909c377483d.sig ``` Fixes: sigstore#658 Signed-off-by: Matt Moore <mattomata@gmail.com>
dekkagaijin
approved these changes
Sep 14, 2021
|
LGTM once e2e_test.go is updated |
|
Whoops done |
dekkagaijin
approved these changes
Sep 14, 2021
|
Also once the latest commit is signed off on 😮💨 |
Signed-off-by: Matt Moore <mattomata@gmail.com>
mattmoor
force-pushed
the
single-3lo
branch
from
6a0015c
to
7e30323
Compare
|
Whoops |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this change, the keyless flow builds a single signer for all of the images, which means a single key and 3LO for all of the references we sign:
$ COSIGN_EXPERIMENTAL=true cosign sign ghcr.io/mattmoor/controller ghcr.io/mattmoor/webhook Generating ephemeral keys... Retrieving signed certificate... Your browser will now be opened to: https://oauth2.sigstore.dev/auth/auth?REDACTED Successfully verified SCT... tlog entry created with index: 693418 Pushing signature to: ghcr.io/mattmoor/controller:sha256-b10f4b2e04cde2e799e080068f162ef668c4db3099382798b5fe1a208023105d.sig tlog entry created with index: 693420 Pushing signature to: ghcr.io/mattmoor/webhook:sha256-ed1b1c778685ae0739cd4c6354fa2d724351b01e998a019d1ddc2909c377483d.sigFixes: #658
Signed-off-by: Matt Moore mattomata@gmail.com
cc @dekkagaijin @dlorenc