Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix cert.URIs #1144

Merged
merged 1 commit into from
May 3, 2023
Merged

fix cert.URIs #1144

merged 1 commit into from
May 3, 2023

Conversation

cpanato
Copy link
Member

@cpanato cpanato commented May 3, 2023

Summary

  • fix cert.URIs
    It is generating "https://gitlab.com/cpanato/testing-cosign/@/refs/heads/main" and that should be "https://gitlab.com/cpanato/testing-cosign@refs/heads/main" for example

Signed-off-by: cpanato <ctadeu@gmail.com>
@cpanato cpanato requested review from wlynch and priyawadhwa May 3, 2023 15:49
@haydentherapper
Copy link
Contributor

Do you have any other testing to do or other issues that need to get fixed? Otherwise we can cut 1.3.1 with the fix

@codecov
Copy link

codecov bot commented May 3, 2023

Codecov Report

Merging #1144 (a285bab) into main (13dcf39) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main    #1144   +/-   ##
=======================================
  Coverage   56.02%   56.02%           
=======================================
  Files          50       50           
  Lines        2904     2904           
=======================================
  Hits         1627     1627           
  Misses       1133     1133           
  Partials      144      144           
Impacted Files Coverage Δ
pkg/identity/gitlabcom/principal.go 62.61% <100.00%> (ø)

@priyawadhwa priyawadhwa merged commit 3d45d3e into sigstore:main May 3, 2023
@cpanato cpanato deleted the fix-gitlab-subject branch May 3, 2023 16:19
@cpanato
Copy link
Member Author

cpanato commented May 3, 2023

Do you have any other testing to do or other issues that need to get fixed? Otherwise we can cut 1.3.1 with the fix

Dont think we have, just a few improvements in the tests but that will take more time, and will apply for GitHub and others as well

@cpanato
Copy link
Member Author

cpanato commented May 3, 2023

sounds good a patch cut, thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants