Fix docker-compose file #1560
Merged
Fix docker-compose file #1560
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add environment variable FULCIO_CONFIG to allow providing an alternate configuration file rather than overwriting the default one. If a testing environment overwrote the git-committed config/config.jsn, it would pollute the repository checkout and be difficult to reuse on subsequent test runs. Signed-off-by: Colleen Murphy <colleenmurphy@google.com>
The ctfe_init container uses a persistent volume to store the tree head ID among other things from previous runs. However, the mysql container is not guaranteed to reuse the same data directory when it is destroyed and recreated, so it may come up empty. When this happens, but the CT log is configured for an existing tree, then signing objects will fail with a Not Found error. This change adds a persistent volume to the docker-compose file for mysql so that the database can live on and be consistent with the CT log's configuration. Signed-off-by: Colleen Murphy <colleenmurphy@google.com>
cmurphy
force-pushed
the
docker-compose-fixes
branch
from
321e885
to
41f9b9e
Compare
haydentherapper
approved these changes
Feb 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make config path configurable
Add environment variable FULCIO_CONFIG to allow providing an alternate
configuration file rather than overwriting the default one. If a testing
environment overwrote the git-committed config/config.jsn, it would
pollute the repository checkout and be difficult to reuse on subsequent
test runs.
Needed by sigstore/cosign#3499
Add persistent volume for mysql
The ctfe_init container uses a persistent volume to store the tree head
ID among other things from previous runs. However, the mysql container
is not guaranteed to reuse the same data directory when it is destroyed
and recreated, so it may come up empty. When this happens, but the CT
log is configured for an existing tree, then signing objects will fail
with a Not Found error. This change adds a persistent volume to the
docker-compose file for mysql so that the database can live on and be
consistent with the CT log's configuration.
Summary
Release Note
Documentation