generated from sigstore/sigstore-project-template
-
Notifications
You must be signed in to change notification settings - Fork 62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for systemd socket activation #223
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Iavael <905853+iavael@users.noreply.github.com>
iavael
force-pushed
the
feature/socket-activation
branch
2 times, most recently
from
January 17, 2023 13:39
8552d71
to
cb57b6d
Compare
Signed-off-by: Iavael <905853+iavael@users.noreply.github.com>
iavael
force-pushed
the
feature/socket-activation
branch
from
January 17, 2023 13:42
cb57b6d
to
1d44296
Compare
cpanato
reviewed
Jan 17, 2023
Signed-off-by: Iavael <905853+iavael@users.noreply.github.com>
Signed-off-by: Iavael <905853+iavael@users.noreply.github.com>
wlynch
requested changes
Jan 18, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for putting this together! 🙏
Some comments, primarily to be defensive if this flag is invoked on a non-systemd machine.
cc @eddiezane in case you have any other comments |
Signed-off-by: Iavael <905853+iavael@users.noreply.github.com>
…o cache daemon Signed-off-by: Iavael <905853+iavael@users.noreply.github.com>
wlynch
approved these changes
Jan 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
In this PR there are systemd user units for gitsign-credential-cache for a better integration on linux systemd with systemd. Also gitsign-credential-cache was modified for socket activation support.
Release Note
Added parameter -s to gitsign-credential-cache for socket activation support
Documentation
README was adjusted
Closes #222