Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update protoc, add dependabot #99

Merged
merged 2 commits into from
Jul 26, 2023
Merged

Conversation

haydentherapper
Copy link
Collaborator

I was running into an error with the Docker container updating its apt cache, updating to the latest protoc image fixed it.

Also added dependabot to keep it up to date.

Summary

Release Note

Documentation

I was running into an error with the Docker container updating its apt
cache, updating to the latest protoc image fixed it.

Also added dependabot to keep it up to date.

Signed-off-by: Hayden Blauzvern <hblauzvern@google.com>
Makefile Outdated Show resolved Hide resolved
@haydentherapper
Copy link
Collaborator Author

@woodruffw One other thing I noticed, there's a file permissions issue with the created codegen for rust. When I run make again, I get:

Building development docker image
docker build -t protobuf-specs-build .
error checking context: no permission to read from '/usr/local/google/home/hblauzvern/protobuf-specs/gen/pb-rust/codegen/target/debug/incremental/sigstore_protobuf_specs_codegen-219stdjo4fqmo/s-gn63o9g6ki-d2358w.lock'
make: *** [Makefile:66: docker-image] Error 1

Do you know where I should update for this?

@haydentherapper
Copy link
Collaborator Author

There's reports of this issue in rust-lang/cargo#6757, so I assume we just need to chown some directory

@woodruffw
Copy link
Member

One other thing I noticed, there's a file permissions issue with the created codegen for rust. When I run make again, I get:

Hmm, I haven't seen this before. I wonder if this is because cargo is trying to read/write to a directory that's shared with the host? I'll try and repro tomorrow.

@kommendorkapten
Copy link
Member

I was running into an error with the Docker container updating its apt cache, updating to the latest protoc image fixed it.

Did you try running make docker-image-no-cache @haydentherapper ?

I was running into similar issues so that's why I added the target drop the caches.

@jleightcap
Copy link
Contributor

There's reports of this issue in rust-lang/cargo#6757, so I assume we just need to chown some directory

I ran into this intermittently only when building the same rust target multiple times in a row, so I don't believe this should affect anything other than develop-time. My workaround was chown -R gen/pb-rust/codegen/target as you mention -- I'm not well-versed in docker container best practices, but chown-ing would at worst be a no-op, I imagine?

Signed-off-by: Hayden Blauzvern <hblauzvern@google.com>
@haydentherapper
Copy link
Collaborator Author

Running sudo chown -R $(whoami) gen/pb-rust/codegen/target resolves this. Not sure why this is needed though, as files generated with the container for other languages don't have this issue.

@haydentherapper haydentherapper merged commit 028dbf6 into sigstore:main Jul 26, 2023
9 checks passed
@haydentherapper haydentherapper deleted the update branch July 26, 2023 20:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants