Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove unused RekorVersion API definition #1101

Merged
merged 1 commit into from
Oct 6, 2022

Conversation

bobcallaway
Copy link
Member

The Rekor version endpoint was removed in #1022 but failed to remove the definition in openapi.yaml; this removes it and deletes the dead code generated for it.

Signed-off-by: Bob Callaway bcallaway@google.com

Signed-off-by: Bob Callaway <bcallaway@google.com>
@bobcallaway bobcallaway requested a review from a team as a code owner October 6, 2022 11:23
@codecov-commenter
Copy link

codecov-commenter commented Oct 6, 2022

Codecov Report

Merging #1101 (f2b77e4) into main (a47adc1) will decrease coverage by 0.05%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #1101      +/-   ##
==========================================
- Coverage   63.73%   63.68%   -0.06%     
==========================================
  Files          82       82              
  Lines        7567     7567              
==========================================
- Hits         4823     4819       -4     
- Misses       2119     2121       +2     
- Partials      625      627       +2     
Flag Coverage Δ
e2etests 48.43% <ø> (ø)
unittests 40.75% <ø> (-0.06%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/types/alpine/v0.0.1/entry.go 71.13% <0.00%> (-2.44%) ⬇️
pkg/types/helm/v0.0.1/entry.go 47.47% <0.00%> (ø)
pkg/types/rekord/v0.0.1/entry.go 68.42% <0.00%> (+0.65%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@priyawadhwa priyawadhwa merged commit 550bc6a into sigstore:main Oct 6, 2022
@github-actions github-actions bot added this to the v1.0.0 milestone Oct 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants