Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pass treeSize and rootHash to avoid trillian import #1513

Merged
merged 1 commit into from
May 30, 2023

Conversation

bobcallaway
Copy link
Member

@bobcallaway bobcallaway commented May 29, 2023

Summary

Redefines util.CreateAndSignCheckpoint to take treeSize and rootHash as arguments to avoid adding dependency on github.com/google/trillian.

Signed-off-by: Bob Callaway <bcallaway@google.com>
@bobcallaway bobcallaway requested a review from a team as a code owner May 29, 2023 17:36
@codecov
Copy link

codecov bot commented May 29, 2023

Codecov Report

Merging #1513 (aa96f2d) into main (55a5a33) will not change coverage.
The diff coverage is 87.50%.

@@           Coverage Diff           @@
##             main    #1513   +/-   ##
=======================================
  Coverage   66.94%   66.94%           
=======================================
  Files          83       83           
  Lines        8406     8406           
=======================================
  Hits         5627     5627           
  Misses       2103     2103           
  Partials      676      676           
Flag Coverage Δ
e2etests 48.31% <87.50%> (-0.03%) ⬇️
unittests 47.78% <50.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/api/tlog.go 31.57% <50.00%> (ø)
pkg/api/entries.go 64.87% <100.00%> (ø)
pkg/util/checkpoint.go 77.77% <100.00%> (ø)
pkg/witness/publish_checkpoint.go 89.21% <100.00%> (ø)

... and 1 file with indirect coverage changes

@bobcallaway bobcallaway merged commit 67cc9e5 into sigstore:main May 30, 2023
@github-actions github-actions bot added this to the v1.2.2 milestone May 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants