Refactor Identities API #1611
Merged
Refactor Identities API #1611
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of providing raw strings that are up to the client to determine how to parse, return typed structs. Encoded keys are included and should be parsed based on the returned type. Signed-off-by: Hayden Blauzvern <hblauzvern@google.com>
|
FYI: TUF requires a new root because go-tuf dropped support for hex-encoded keys, as they were not conformant to the TUF spec. |
Codecov Report
@@ Coverage Diff @@
## main #1611 +/- ##
==========================================
- Coverage 67.07% 66.90% -0.18%
==========================================
Files 83 83
Lines 8441 8452 +11
==========================================
- Hits 5662 5655 -7
- Misses 2101 2118 +17
- Partials 678 679 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
|
bobcallaway
reviewed
Aug 4, 2023
bobcallaway
previously approved these changes
Aug 4, 2023
Signed-off-by: Hayden Blauzvern <hblauzvern@google.com>
|
@bobcallaway Agreed on the minor bump. |
bobcallaway
approved these changes
Aug 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of providing raw strings that are up to the client to determine how to parse, return typed structs. Encoded keys are included and should be parsed based on the returned type.
Summary
Release Note
Documentation