Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

return full entryID on HTTP 409 responses #1650

Merged
merged 1 commit into from
Aug 29, 2023

Conversation

bobcallaway
Copy link
Member

Fixes #1649

Signed-off-by: Bob Callaway <bcallaway@google.com>
@bobcallaway bobcallaway requested a review from a team as a code owner August 29, 2023 12:58
@codecov
Copy link

codecov bot commented Aug 29, 2023

Codecov Report

Merging #1650 (aee6530) into main (6208b39) will decrease coverage by 17.99%.
Report is 2 commits behind head on main.
The diff coverage is 55.55%.

@@             Coverage Diff             @@
##             main    #1650       +/-   ##
===========================================
- Coverage   66.93%   48.95%   -17.99%     
===========================================
  Files          88       88               
  Lines        8804     8811        +7     
===========================================
- Hits         5893     4313     -1580     
- Misses       2213     3650     +1437     
- Partials      698      848      +150     
Flag Coverage Δ
e2etests 48.95% <55.55%> (-0.01%) ⬇️
unittests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
pkg/api/entries.go 65.42% <55.55%> (-0.34%) ⬇️

... and 46 files with indirect coverage changes

@bobcallaway bobcallaway merged commit f3d6483 into sigstore:main Aug 29, 2023
14 checks passed
@github-actions github-actions bot added this to the v1.2.2 milestone Aug 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Location header in HTTP 409 response does not include treeID
2 participants