use a single validator library in rekor-cli #1818
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Bob Callaway <bcallaway@google.com>
| @@ -60,13 +63,14 @@ func validateSHA256Value(v string) error { | |||
| hash = split[1] | |||
| } | |||
|
|
|||
| s := struct { | |||
| Prefix string `validate:"omitempty,oneof=sha256"` | |||
| Hash string `validate:"required,len=64,hexadecimal"` | |||
There was a problem hiding this comment.
qq, i noticed on the other PR, we dropped required from required,email - is this behavior equivalent with this new library?
There was a problem hiding this comment.
yes, the check fails if the criteria isn't met
Codecov Report
@@ Coverage Diff @@
## main #1818 +/- ##
===========================================
+ Coverage 47.54% 66.40% +18.85%
===========================================
Files 78 90 +12
Lines 8260 9057 +797
===========================================
+ Hits 3927 6014 +2087
+ Misses 3940 2309 -1631
- Partials 393 734 +341
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Signed-off-by: Bob Callaway <bcallaway@google.com>
|
@steiza fyi |
haydentherapper
approved these changes
Nov 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Release Note
Documentation