Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix panic for DSSE canonicalization #1923

Merged
merged 1 commit into from
Dec 20, 2023

Conversation

haydentherapper
Copy link
Contributor

Handles if the array of signatures contains missing data.

Summary

Release Note

Documentation

Handles if the array of signatures contains missing data.

Signed-off-by: Hayden Blauzvern <hblauzvern@google.com>
Copy link

codecov bot commented Dec 20, 2023

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (7788eb3) 66.40% compared to head (2e08c53) 47.60%.

Files Patch % Lines
pkg/types/dsse/v0.0.1/entry.go 25.00% 2 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##             main    #1923       +/-   ##
===========================================
- Coverage   66.40%   47.60%   -18.81%     
===========================================
  Files          92       92               
  Lines        9193     9197        +4     
===========================================
- Hits         6105     4378     -1727     
- Misses       2345     3943     +1598     
- Partials      743      876      +133     
Flag Coverage Δ
e2etests 47.60% <25.00%> (-0.01%) ⬇️
unittests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@haydentherapper haydentherapper merged commit 6020532 into sigstore:main Dec 20, 2023
14 checks passed
@github-actions github-actions bot added this to the v1.2.2 milestone Dec 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants