Better error handling in backfill script #2148
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2148 +/- ##
===========================================
- Coverage 66.46% 48.44% -18.02%
===========================================
Files 92 80 -12
Lines 9258 6659 -2599
===========================================
- Hits 6153 3226 -2927
- Misses 2359 3035 +676
+ Partials 746 398 -348
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
haydentherapper
approved these changes
Jun 13, 2024
bobcallaway
approved these changes
Jun 19, 2024
- defer the channel close so that the channel is closed no matter what - always report parse and insert errors - handle a cancelled context in the sql query - clean up inappropriate log.Fatal calls leftover from an earlier refactor - don't print success if insertion failed Signed-off-by: Colleen Murphy <colleenmurphy@google.com>
If there is a persistent problem with one of the network connections, continuing to attempt the insertion is a waste of time, and if the list of errors gets too long before the script finishes or is interrupted, it becomes impossible to tell when it started failing and therefore where to restart the script from. This change sets a limit on the maximum number of failures to tolerate before exiting the script. Parsing errors are related to the format of the data and don't have implications on the overall success of the script on other data, so no change is implemented for parsing errors. Signed-off-by: Colleen Murphy <colleenmurphy@google.com>
haydentherapper
approved these changes
Jun 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix error handling for backfill
refactor
Abort backfill after limited errors
If there is a persistent problem with one of the network connections,
continuing to attempt the insertion is a waste of time, and if the list
of errors gets too long before the script finishes or is interrupted, it
becomes impossible to tell when it started failing and therefore where
to restart the script from. This change sets a limit on the maximum
number of failures to tolerate before exiting the script. Parsing errors
are related to the format of the data and don't have implications on the
overall success of the script on other data, so no change is implemented
for parsing errors.
Summary
Release Note
Documentation