alert on remaining disk instead of utilization #658
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ceridwen Coghlan <cdriskill@google.com>
There was a problem hiding this comment.
Awesome work on the MQL!
Looking at the charts, in staging, it looks like there is a DB where free space is currently less than 20 GiB - link
This DB is only 10gb and no longer growing, but I could imagine this would be true for a brand new shard DB also.
What about combining both of these alerts? Alert if disk utilization is > 98% && less than <20 GiB of space.
Signed-off-by: Ceridwen Coghlan <cdriskill@google.com>
haydentherapper
approved these changes
Jun 9, 2023
|
Thanks Hayden, will merge sometime next week once the terraform gods have blessed us by functioning. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes https://github.com/sigstore/public-good-instance/issues/1246
Swaps the alert to alert on the difference between disk quota and bytes used rather than the disk utilization metric.
Also MQL is a pain.
Creating this as a draft since I don't want to submit until after the staging terraform state issues are resolved.