Specify the service account issuer for kubernetes clusters #722
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hectorj2f
force-pushed
the
set_service_account_issuer
branch
from
5f0b817
to
9b17f32
Compare
Signed-off-by: Hector Fernandez <hector@chainguard.dev>
hectorj2f
force-pushed
the
set_service_account_issuer
branch
from
9b17f32
to
cb6e80a
Compare
hectorj2f
changed the title
k4leung4
reviewed
Aug 9, 2023
| @@ -95,7 +95,7 @@ if [ "${NEED_TO_UPDATE_FULCIO_CONFIG}" == "true" ]; then | |||
| echo "Fixing Fulcio config for < 1.23.X Kubernetes" | |||
| curl -Ls "${FULCIO}" | sed 's@https://kubernetes.default.svc.cluster.local@https://kubernetes.default.svc@' | kubectl apply -f - | |||
| else | |||
| curl -Ls "${FULCIO}" | sed 's@"IssuerURL": "https://kubernetes.default.svc",@"IssuerURL": "https://kubernetes.default.svc.cluster.local",@' | kubectl apply -f - | |||
| curl -Ls "${FULCIO}" | sed 's@"IssuerURL": "https://kubernetes.default.svc.cluster.local",@"IssuerURL": "https://kubernetes.default.svc.cluster.local",@' | kubectl apply -f - | |||
There was a problem hiding this comment.
we should be able to replace this line, as your change would be replacing it with the same thing
There was a problem hiding this comment.
True! I missed this!
k4leung4
previously approved these changes
Aug 9, 2023
Signed-off-by: Hector Fernandez <hector@chainguard.dev>
Closed
bobcallaway
approved these changes
Aug 9, 2023
wlynch
approved these changes
Aug 9, 2023
Gregory-Pereira
pushed a commit
to Gregory-Pereira/scaffolding
that referenced
this pull request
Nov 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
I've made some changes to setup-kind actions to set a specific service account issuer. This might fix the current mismatch for the OIDC kubernetes provider when deploying the latest version on a kind cluster.
Release Note
Documentation