Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs] update getting-started to work with cosign 2.1 #803

Merged
merged 2 commits into from
Nov 13, 2023

Conversation

NissesSenap
Copy link
Contributor

@NissesSenap NissesSenap commented Oct 26, 2023

Summary

Trying to follow the getting started guide is currently rather hard due to the cosign version used is rather old.
To make it easier I updated the documentation.

Release Note

NONE

Documentation

- clean upe markdwon
- update instructions to work with cosign 2.1

Signed-off-by: Edvin Norling <edvin.norling@kognic.com>
@NissesSenap
Copy link
Contributor Author

I have tested all the commands with cosign version 2.1.0 I chose not to update the example output, personally I think it's close enough, and I think people will understand.

I also tried to run with cosign 2.2.0, but then I got the following error

Handling connection for 8080
Error: signing registry.local:5001/sigstore/demo@sha256:95bb686784c1d0deafc656486ae562e0420ab2b9a2f4c307a6571d401ce00e3e: [POST /api/v1/log/entries][422] createLogEntry default  &{Code:422 Message:invalid kind value: "dsse"}
main.go:74: error during command execution: signing registry.local:5001/sigstore/demo@sha256:95bb686784c1d0deafc656486ae562e0420ab2b9a2f4c307a6571d401ce00e3e: [POST /api/v1/log/entries][422] createLogEntry default  &{Code:422 Message:invalid kind value: "dsse"}

I'm 90% sure this is due to sigstore/cosign#3113.

I think this PR is better than the current state, but ideally it should work with 2.2.0.
Furthermore, I feel that I'm a bit out of depth trying to debug why this happens, but looking at the PR it seems to be a change in the way of working.
If anyone with more knowledge about the dsse change, please share.

getting-started.md Outdated Show resolved Hide resolved
Co-authored-by: Bob Callaway <bobcallaway@users.noreply.github.com>
Signed-off-by: Edvin N <edvin.norling@gmail.com>
@NissesSenap
Copy link
Contributor Author

Thanks for the fix @bobcallaway , I was at PTO so that why I was so slow to update.
Is there anything else needed for the PR you feel?

@bobcallaway bobcallaway merged commit 1268d83 into sigstore:main Nov 13, 2023
16 checks passed
@NissesSenap NissesSenap deleted the cosign_2_2 branch December 14, 2023 21:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants