leverage Vault token helpers approach while obtaining Vault token #104
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cpanato
reviewed
Jul 26, 2021
Signed-off-by: Batuhan Apaydın <batuhan.apaydin@trendyol.com>
bobcallaway
reviewed
Jul 26, 2021
mtrmac
pushed a commit
to mtrmac/sigstore
that referenced
this pull request
Mar 10, 2023
* Add kms to sign-blob Signed-off-by: Priya Wadhwa <priyawadhwa@google.com> * Add documentation for KMS to README (sigstore#101) Signed-off-by: Priya Wadhwa <priyawadhwa@google.com> * Add the public key from KMS (sigstore#100) Signed-off-by: Dan Lorenc <dlorenc@google.com> Signed-off-by: Priya Wadhwa <priyawadhwa@google.com> * remove unnecessary image input to sign function Signed-off-by: Priya Wadhwa <priyawadhwa@google.com> * Add kms support to verify-blob as well Signed-off-by: Priya Wadhwa <priyawadhwa@google.com> * Fix lint Signed-off-by: Priya Wadhwa <priyawadhwa@google.com> * fix test Signed-off-by: Priya Wadhwa <priyawadhwa@google.com> Co-authored-by: dlorenc <dlorenc@google.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is a concept called Token Helpers in Vault. By default, the Vault CLI will store the generated token on disk in the
~/.vault-tokenfile. So, I realized that even though we could not set theVAULT_TOKENenv variable, we can still obtain the Vault token from the file with the help of this feature. So, this PR will add that support to the Vault client initialization process.Btw, this is just an idea, so please feel free to comment it out.