Handle invalid elliptic curve gracefully when verifying signature #728
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
An invalid curve caused a panic when verifying. Note that this does not affect Rekor or Fulcio. In both cases, an invalid curve will be caught when unmarshalling the PKIX public key, which checks for curve validity. Caught by OSS-Fuzz! Signed-off-by: Hayden Blauzvern <hblauzvern@google.com>
bobcallaway
reviewed
Oct 5, 2022
Signed-off-by: Hayden Blauzvern <hblauzvern@google.com>
bobcallaway
previously approved these changes
Oct 5, 2022
Signed-off-by: Hayden Blauzvern <hblauzvern@google.com>
haydentherapper
dismissed stale reviews from asraa and bobcallaway
via
ea2b228
asraa
approved these changes
Oct 5, 2022
dlorenc
approved these changes
Oct 5, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An invalid curve caused a panic when verifying. Note that this does not affect Rekor or Fulcio. In both cases, an invalid curve will be caught when unmarshalling the PKIX public key, which checks for curve validity.
Caught by OSS-Fuzz!
Signed-off-by: Hayden Blauzvern hblauzvern@google.com
Summary
Release Note
Documentation