WIP: potential fix for #480 #486
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for opening this pull request! Each pull request require an update in the CHANGELOG. Please update it based on your changes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@sky-nunomarcos can you give this branch a try and see if it resolves the performance issue you see?
Am I correct in assuming that you're using Summaries? Are you setting
maxAgeSecondsandageBuckets?It sounds like
maxAgeSecondsandageBucketsshould be set normally. They weren't set when they were added to prom-client to avoid a breaking change. I don't think the rotation interval has to be exact though, so we can batch rotations up at least.