Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fails to compile with GOOS=linux, GOARCH=386 #65

Closed
ipsi opened this issue Mar 25, 2021 · 2 comments
Closed

Fails to compile with GOOS=linux, GOARCH=386 #65

ipsi opened this issue Mar 25, 2021 · 2 comments

Comments

@ipsi
Copy link

ipsi commented Mar 25, 2021

I'm not sure if you're intentionally avoiding 32-bit systems, but if I compile an application using go-ora with the flags GOOS=linux GOARCH=386, I get the following error:

# github.com/sijms/go-ora/advanced_nego
../../../../go/pkg/mod/github.com/sijms/go-ora@v0.0.0-20210313181832-b64036f0a8e4/advanced_nego/advanced_nego.go:40:9: constant 3735928559 overflows int
../../../../go/pkg/mod/github.com/sijms/go-ora@v0.0.0-20210313181832-b64036f0a8e4/advanced_nego/advanced_nego.go:120:17: constant 3735928559 overflows int
../../../../go/pkg/mod/github.com/sijms/go-ora@v0.0.0-20210313181832-b64036f0a8e4/advanced_nego/supervisor_service.go:60:10: constant 3735928559 overflows int
../../../../go/pkg/mod/github.com/sijms/go-ora@v0.0.0-20210313181832-b64036f0a8e4/advanced_nego/supervisor_service.go:91:17: constant 3735928559 overflows int

These errors can probably be fixed by having the functions explicitly return int64, I think.

@sijms
Copy link
Owner

sijms commented Mar 25, 2021

I fix it. can you check if there is any errors

I will also test the driver against x32 system to detect runtime errors

@ipsi
Copy link
Author

ipsi commented Mar 26, 2021

Cool, builds successfully now - thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants