DEV-3809: Fix crash of Decode function.

[shmuelnatan]

No description provided.

[shmuelhazan]

Can't we just return if !xml_parse_doc?

[shmuelhazan]

Don't we want to somehow tell the caller about the issue?

[shmuelnatan]

Do you want me to change the return value of Decode to a string or int?

[shmuelhazan]

Do you want me to change the return value of Decode to a string or int?

What does it currently do in a case of an error?

[shmuelnatan]

Depends on the error. There are two options:

1. throwing runtime error exception.
2. crash (which won't happen now due to our fix).
   Otherwise, there's no indication of an error.

[shmuelhazan]

Depends on the error. There are two options:

1. throwing runtime error exception.
2. crash (which won't happen now due to our fix).
   Otherwise, there's no indication of an error.

This crash was not a runtime indication. Just a nullptr dereference.
I think that we can throw a runtime exception then.

[shmuelnatan]

done