Update for tornado 6 #6
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since the use of io_loop as a function parameter in tornado is removed, IOLoop.current() is the way to get the instance and run functions on it
Task was also deprecated and removed in tornado 6, but it's also not useful anymore since the function "fetch" that was being called also no longer supports the "callback" argument that Task was supplying. It instead recommends to use the returned Future instance instead, which is the same as what Task used to do.
ViViDboarder
requested changes
Nov 17, 2023
Comment on lines
+47
to
+48
| # Use the default IO loop | ||
| self.io_loop = IOLoop.current() |
There was a problem hiding this comment.
Is this used anywhere since it's not going into LongPollingTransport?
There was a problem hiding this comment.
self.io_loop is used later in the Client class on lines 161 and 210.
There was a problem hiding this comment.
I wonder if that can be refactored too, but no need to figure that out now.
ViViDboarder
approved these changes
Nov 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tornado 6 removed the
io_loopparameter, which removed the ability to create and pass in your own instance of it. This PR makes baiocas compatible with tornado 6 by removing the ability to create or pass in IOLoops to tornado. For code that runs functions on IOLoops created the old way,IOLoop.current()is used to get the current instance instead.Tornado 6 also removed the
Taskfunction (deprecated in v5), which adapted callback-based functions to be used in coroutines.Taskwas used to callAsyncHTTPClient.fetchand get aFutureinstance. However,fetchin v6 removed thecallbackargument and returns aFutureinstance directly (documentation), so this PR changes baiocas to just call the function directly and use its return value.Test cases pass.