Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

readFile() should always return a Buffer #92

Closed
JbIPS opened this issue Jul 11, 2017 · 0 comments
Closed

readFile() should always return a Buffer #92

JbIPS opened this issue Jul 11, 2017 · 0 comments
Assignees
@JbIPS
Labels
enhancement

Comments

@JbIPS
Copy link
Collaborator

JbIPS commented Jul 11, 2017

We shouldn't try to guess the encoding of a file. For consistency, we should always return a Buffer, letting the user choose how to deal with it.
@JbIPS JbIPS self-assigned this Jul 11, 2017
@lexoyo lexoyo mentioned this issue Sep 20, 2017
Closed
lexoyo added a commit to lexoyo/unifile that referenced this issue Sep 22, 2017
@lexoyo
WIP: always return a Buffer for readFile, fixes silexlabs#92 and sile…
0f4731a 
…xlabs#94
lexoyo added a commit to lexoyo/unifile that referenced this issue Sep 22, 2017
@lexoyo
WIP: always return a Buffer for readFile, fixes silexlabs#92 and sile…
144063c 
…xlabs#94
lexoyo added a commit to lexoyo/unifile that referenced this issue Sep 22, 2017
@lexoyo
always return a Buffer for readFile, fixes silexlabs#92 and silexlabs#94
ab584c5
@lexoyo lexoyo mentioned this issue Sep 26, 2017
Merged
@JbIPS JbIPS closed this as completed in #98 Sep 26, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@JbIPS JbIPS

Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@JbIPS