This repository has been archived by the owner on Sep 14, 2018. It is now read-only.
Add Twig environment service parameter to TwigDataCollector constructor #126
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a BC break introduced upstream in 860575a88240a1eca46fc9a660212816827d32df
|
Indeed, we need to fix the BC break upstream. This PR is still valid to get the new feature though. |
|
Thank you @GawainLynch. |
fabpot
added a commit
that referenced
this pull request
Nov 7, 2017
…tor constructor (GawainLynch) This PR was merged into the 2.0.x-dev branch. Discussion ---------- Add Twig environment service parameter to TwigDataCollector constructor This is a BC break introduced upstream in symfony/symfony#24236 Commits ------- de4ce77 Add Twig environment service parameter to TwigDataCollector constructor
symfony-splitter
pushed a commit
to symfony/twig-bridge
that referenced
this pull request
Nov 7, 2017
…o0NL) This PR was squashed before being merged into the 3.4 branch (closes #24851). Discussion ---------- [TwigBridge] Fix BC break due required twig environment | Q | A | ------------- | --- | Branch? | 3.4 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes/no | Fixed tickets | symfony/symfony#24236 (comment) | License | MIT | Doc PR | symfony/symfony-docs#... <!--highly recommended for new features--> See ezsystems/ezplatform-design-engine#12 + silexphp/Silex-WebProfiler#126 + bolt/bolt#7154 Sorry for that :) cc @fabpot Commits ------- 243e4b2 [TwigBridge] Fix BC break due required twig environment
nicolas-grekas
added a commit
to symfony/symfony
that referenced
this pull request
Nov 7, 2017
…o0NL) This PR was squashed before being merged into the 3.4 branch (closes #24851). Discussion ---------- [TwigBridge] Fix BC break due required twig environment | Q | A | ------------- | --- | Branch? | 3.4 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes/no | Fixed tickets | #24236 (comment) | License | MIT | Doc PR | symfony/symfony-docs#... <!--highly recommended for new features--> See ezsystems/ezplatform-design-engine#12 + silexphp/Silex-WebProfiler#126 + bolt/bolt#7154 Sorry for that :) cc @fabpot Commits ------- 243e4b2 [TwigBridge] Fix BC break due required twig environment
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a BC break introduced upstream in symfony/symfony#24236