This repository has been archived by the owner on Jul 4, 2018. It is now read-only.
fixed compatibility with 2.7 #1142
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fabpot
added a commit
that referenced
this pull request
Apr 11, 2015
This PR was merged into the 1.3 branch. Discussion ---------- fixed compatibility with 2.7 replaces #1141 Note that 2.7 beta1 won't work because symfony/symfony#14313 was merged after the release. Commits ------- 426cde5 fixed compatibility with 2.7
nicolas-grekas
added a commit
to symfony/symfony
that referenced
this pull request
Apr 24, 2015
…l.exception does not led to a Response" (nicolas-grekas) This PR was merged into the 2.7 branch. Discussion ---------- Revert "[HttpKernel] Throw a LogicException when kernel.exception does not led to a Response" | Q | A | ------------- | --- | Bug fix? | no | New feature? | yes | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | - | License | MIT | Doc PR | - This partially reverts commit 22f4807: it broke BC (see silexphp/Silex#1142 and 22f4807#commitcomment-10857485) Commits ------- 10c5ffb Revert "[HttpKernel] Throw a LogicException when kernel.exception does not led to a Response"
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
replaces #1141
Note that 2.7 beta1 won't work because symfony/symfony#14313 was merged after the release.