Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Release 3.2.0 -- allow null as the default in getArray #26

Merged
merged 3 commits into from
Jul 17, 2024
Merged

Release 3.2.0 -- allow null as the default in getArray #26

merged 3 commits into from
Jul 17, 2024

Conversation

briskt
Copy link
Contributor

@briskt briskt commented Jul 16, 2024

Added

  • Make the default parameter in getArray nullable

@briskt briskt mentioned this pull request Jul 16, 2024
Merged
hobbitronics
hobbitronics approved these changes Jul 17, 2024
View reviewed changes
Copy link

@hobbitronics hobbitronics left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one question, otherwise looks good

tests/unit/EnvTest.php Outdated Show resolved Hide resolved
@briskt briskt merged commit 9a60ee2 into master Jul 17, 2024
1 check passed
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Jul 17, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hobbitronics hobbitronics hobbitronics approved these changes

@forevermatt forevermatt Awaiting requested review from forevermatt

@mtompset mtompset Awaiting requested review from mtompset

@jason-jackson jason-jackson Awaiting requested review from jason-jackson

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@briskt @hobbitronics @jason-jackson