Allow to use WinForms designer #224
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Those were added as a hack previously and are no longer necessary now that VS learned to open files from sdk-style projects in designer.
This change adds the missing pieces that enables the files to be opened in WinForms designer on Windows. This requires Visual Studio 2019 >= 16.8 (or JetBrains Rider).
35 tasks
|
Building on AppVeyor fails, maybe because the current VS version (16.8) isn't yet available there. |
There was a problem hiding this comment.
Reviewed 31 of 31 files at r1.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @ermshiperete)
src/ChorusMerge/app.config, line 3 at r1 (raw file):
<?xml version="1.0"?> <configuration> <startup><supportedRuntime version="v4.0" sku=".NETFramework,Version=v4.6.1"/></startup></configuration>
Just making sure that we don't need something else to replace this.
3 tasks
We have to set PlatformTarget explicitly, otherwise msbuild will make the executables x86 because icu4c contains platform dependent native binaries. However, our icu.net library expects to find the binaries for both x86 and x64, so using AnyCPU for the executable is acceptable. For similar reasons we have to set RuntimeIdentifiers which is needed when building with .NET 5 on AppVeyor - without it we get an error that there is no target for 'net461/win7-x86'.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change adds the missing pieces that enables the files to be opened in WinForms designer on Windows. This requires Visual Studio 2019 >= 16.8 (or JetBrains Rider). This change also removes the designer projects that were added as a temporary hack.
Part of sillsdev/libpalaso#993
This change is