Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolving a Latex Rendering Problem #71

Closed
wants to merge 4 commits into from
Closed

Conversation

enfycius
Copy link

@enfycius enfycius commented Aug 18, 2023

This change is Reviewable

@stackblitz
Copy link

stackblitz bot commented Aug 18, 2023

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@enfycius
Copy link
Author

enfycius commented Aug 18, 2023

It is my mistake to upload my Notion API key. However, I am fine because I already removed the key and reissued a new key.

@hatton
Copy link
Member

hatton commented Aug 19, 2023

@enfycius Great start. Here are some next steps for you:

  • Make sure that the only things in the diff are what is needed for this change. There should not be anything else (for example, do not add additional parameters to the ts command).
  • The package-lock.json you submitted removed the resolved and integrity fields. I don't know what causes this, but see this.
  • Do not change the visibility of private members by adding export, even if this helps you write the unit test. Doing that is a big enough deal that we'd have to have a conversation first to make sure it is really needed. If you need help writing the test without these, just let us know, we can help.
  • Create a named branch. "issue-68/latex-rendering" would be great
  • Squash your commits down to one, with a commit message like "fix: latex rendering (issue Latex Rendering Problem #68)".

Thanks!

@enfycius
Copy link
Author

enfycius commented Aug 20, 2023

@hatton Ok thanks. First, I will have to tackle these things you suggest to me. But, I can't spend more time because of a lab research. So, I really need your help about writing test code without modifying the existing access range.

@enfycius
Copy link
Author

enfycius commented Aug 20, 2023

Of course, If you can provide some time to me, I will have to try a various things. I think that it is possible to test this code without modifying a existing code. For example, I will be able to indirectly test this code through the existing function with the public modifiers.

@enfycius enfycius closed this Aug 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants