Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added support for nfkc_cf normalizer #87

Closed
wants to merge 1 commit into from
Closed

Added support for nfkc_cf normalizer #87

wants to merge 1 commit into from

Conversation

ghost
Copy link

@ghost ghost commented Oct 29, 2018

I added the missing support for the "nfkc_cf" normalizer and a couple of tests to cover it.


This change is Reviewable

@ghost ghost mentioned this pull request Oct 30, 2018
@ermshiperete
Copy link
Member

Thanks for your change! However, I'm a little hesitant to merge it since it would introduce values that don't exist in icu4c. I'm currently working on a change (#89) that adds partial support for Normalizer2 that would give access to the "nfkc_cf" normalizer.

@ermshiperete
Copy link
Member

This has been implemented differently in #89 and #90

@ghost
Copy link
Author

ghost commented Oct 31, 2018

No problem! Glad to see you're implementing Normalizer2. I'll check it out once it hits the Nuget repo.

@ghost ghost deleted the casefold branch December 13, 2018 21:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant