Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Renamed SIL.Media to SIL.Windows.Forms.Media #1325

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

josephmyers
Copy link
Collaborator

@josephmyers josephmyers commented Jun 4, 2024

This change is Reviewable

@josephmyers josephmyers linked an issue Jun 4, 2024 that may be closed by this pull request
8 tasks
@tombogle
Copy link
Contributor

tombogle commented Aug 1, 2024

I wonder if it might be best to split SIL.Media into a utility DLL and a Forms DLL, as we have with the other things. There are only a small handful of WinForms-specific things here.

Copy link

github-actions bot commented Aug 1, 2024

LibPalaso Tests

   17 files  ±0     17 suites  ±0   8m 33s ⏱️ +22s
4 883 tests ±0  4 652 ✅ ±0  231 💤 ±0  0 ❌ ±0 
4 902 runs  ±0  4 658 ✅ ±0  244 💤 ±0  0 ❌ ±0 

Results for commit 0b7a9af. ± Comparison against base commit db9df03.

@josephmyers
Copy link
Collaborator Author

If it's a small handful, would there be any value in absorbing it into an existing library? Is the benefit of a separate dll enough to justify its cost?

@tombogle
Copy link
Contributor

tombogle commented Aug 2, 2024

I don't see any logical fit anywhere else. The only possible place would be Core, but everything uses thats, so I think it would be less than ideal to put it there. Eventually, HearThis will probably become a non-WinForms app (or get a non-WinForms cousin), so breaking the functionality up really does make sense. I don't know enough about the architecture of Bloom, but it would be another possible candidate for using stuff in SIL.Media if it were not WinFoms dependent.

@josephmyers josephmyers removed a link to an issue Aug 15, 2024
8 tasks
@josephmyers
Copy link
Collaborator Author

I'm also fine leaving it as is. The only thing this PR does is make the name less misleading.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants