Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Link to wiki pages #241

Merged
merged 3 commits into from
Dec 14, 2023
Merged

Link to wiki pages #241

merged 3 commits into from
Dec 14, 2023

Conversation

johnml1135
Copy link
Collaborator

@johnml1135 johnml1135 commented Dec 14, 2023

Resolves #239


This change is Reviewable

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (0e04bae) 71.68% compared to head (8d9bcae) 71.68%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #241   +/-   ##
=======================================
  Coverage   71.68%   71.68%           
=======================================
  Files         133      133           
  Lines        5827     5827           
  Branches      924      924           
=======================================
  Hits         4177     4177           
  Misses       1225     1225           
  Partials      425      425           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@ddaspit ddaspit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 2 of 2 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @Enkidu93)

Copy link
Collaborator

@Enkidu93 Enkidu93 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @johnml1135)

@johnml1135 johnml1135 merged commit 3b661c1 into main Dec 14, 2023
2 checks passed
@ddaspit ddaspit deleted the document_settings branch January 4, 2024 21:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add link to NMT Job Settings in swagger
4 participants