#384 - file download error message

[johnml1135]

This change is 

[codecov-commenter]

Codecov Report

Attention: Patch coverage is 0% with 5 lines in your changes are missing coverage. Please review.

Project coverage is 70.77%. Comparing base (85d87f5) to head (dd70bc4).
Report is 1 commits behind head on main.

Files	Patch %	Lines
src/Serval.Client/Client.g.cs	0.00%	5 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #387      +/-   ##
==========================================
- Coverage   70.81%   70.77%   -0.04%     
==========================================
  Files         151      151              
  Lines        7172     7176       +4     
  Branches     1121     1123       +2     
==========================================
  Hits         5079     5079              
- Misses       1638     1642       +4     
  Partials      455      455              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[ddaspit]

Do we know why this error occurred in the first place?

Reviewed all commit messages.
Reviewable status: 0 of 2 files reviewed, all discussions resolved

[johnml1135]

I believe there was a crash when uploading (or similar).

Reviewable status: 0 of 2 files reviewed, all discussions resolved (waiting on @ddaspit)

[ddaspit]

Reviewed 2 of 2 files at r1.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @johnml1135)

---

src/Serval.DataFiles/Controllers/DataFilesController.cs line 137 at r1 (raw file):

    /// <response code="403">The authenticated client cannot perform the operation or does not own the file</response>
    /// <response code="404">The file does not exist</response>
    /// <response code="500">(Likely cause) File should be on the server but is not present due to internal server error.  Please re-upload file.</response>

A 500 can be caused by any exception. I would prefer to make this more generic. Maybe something like:

The data file is corrupted. Please try reuploading or recreating the file.

[johnml1135]

src/Serval.DataFiles/Controllers/DataFilesController.cs line 137 at r1 (raw file):

Previously, ddaspit (Damien Daspit) wrote…

A 500 can be caused by any exception. I would prefer to make this more generic. Maybe something like:

The data file is corrupted. Please try reuploading or recreating the file.

Done.

[ddaspit]

Reviewed 2 of 2 files at r2, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @johnml1135)