Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

start analyzing clearml tasks #431

Merged
merged 1 commit into from
Aug 12, 2024
Merged

start analyzing clearml tasks #431

merged 1 commit into from
Aug 12, 2024

Conversation

johnml1135
Copy link
Collaborator

@johnml1135 johnml1135 commented Jul 11, 2024

save clearml data to local pickle
Plot jobs per week
add violin plot


This change is Reviewable

@johnml1135 johnml1135 requested a review from ddaspit July 11, 2024 20:43
@codecov-commenter
Copy link

codecov-commenter commented Jul 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 61.87%. Comparing base (3520e29) to head (ec97c70).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #431   +/-   ##
=======================================
  Coverage   61.87%   61.87%           
=======================================
  Files         235      235           
  Lines       11880    11880           
  Branches     1519     1519           
=======================================
  Hits         7351     7351           
  Misses       4002     4002           
  Partials      527      527           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@johnml1135
Copy link
Collaborator Author

@ddaspit - are you wanting to review this, or should I just auto-approve scripts like this in the future?

Copy link
Contributor

@ddaspit ddaspit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 4 of 4 files at r2, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @johnml1135)


.gitignore line 48 at r2 (raw file):

.db
*.zip
scripts/projects.pkl

You should just output all of these files to a specific folder, such as scripts/clearml-stats and ignore everything in that folder.

@johnml1135
Copy link
Collaborator Author

.gitignore line 48 at r2 (raw file):

Previously, ddaspit (Damien Daspit) wrote…

You should just output all of these files to a specific folder, such as scripts/clearml-stats and ignore everything in that folder.

Done.

@johnml1135
Copy link
Collaborator Author

scripts/clearml_stats.py line 14 at r3 (raw file):

from matplotlib import pyplot as plt

clearml_stats_path = os.path.join(os.path.dirname(__file__), "clearml_stats")

Add script extraction for the table.

save clearml data to local pickle
Plot jobs per week
add violin plot

Move to normal python file to not save output

minor updates

First round of stats done

A100 loading stats

Reviewer comments

add langtags data
@johnml1135
Copy link
Collaborator Author

.gitignore line 48 at r2 (raw file):

Previously, johnml1135 (John Lambert) wrote…

Done.

@ddaspit - is there anything else that you need to see? Can we merge this?

@johnml1135 johnml1135 merged commit 0cbf32e into main Aug 12, 2024
1 of 2 checks passed
@johnml1135 johnml1135 deleted the clearml_analytics branch August 12, 2024 18:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants