Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure that writer queue is cleared when lock is canceled #486

Merged
merged 1 commit into from
Sep 11, 2024

Conversation

ddaspit
Copy link
Contributor

@ddaspit ddaspit commented Sep 10, 2024

This change is Reviewable

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 57.16%. Comparing base (4f6888a) to head (86cd312).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #486      +/-   ##
==========================================
+ Coverage   57.12%   57.16%   +0.03%     
==========================================
  Files         277      277              
  Lines       14140    14150      +10     
  Branches     1900     1900              
==========================================
+ Hits         8078     8089      +11     
  Misses       5474     5474              
+ Partials      588      587       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@johnml1135 johnml1135 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 3 of 3 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @ddaspit)

@johnml1135 johnml1135 merged commit 56e0b1a into main Sep 11, 2024
3 checks passed
@ddaspit ddaspit deleted the writer-queue branch September 11, 2024 20:03
@ddaspit ddaspit mentioned this pull request Sep 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants