-
-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update typescript to 4.6 #1422
Update typescript to 4.6 #1422
Conversation
The ts-loader package is actuvely maintained, while awesome-typescript-loader hasn't been updated in 4 years.
New Typescript version is stricter about uninitialized properties, and produced two compiler errors with our current code. I fixed them in two different ways, based on what appeared to be the intent of the code in each case.
There's also a change to the Dockerfile for next-app in here, because while buildx appears to build that file as-is just fine, my Docker installation (which isn't using buildx) complains about the missing |
I think it's fine to fix it up. For the record, everyone should have |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM this is a welcome upgrade, Robin!
Description
Update Typescript to 4.6 so it matches the Typescript version used in Playwright and Svelte, to avoid future problems.
Fixes #1325.
Type of Change
Only keep lines below that describe this change, then delete the rest.
Testing on your branch
Please describe how to test and/or verify your changes. Provide instructions so we can reproduce. Please also provide relevant test data as necessary. These instructions will be used for QA testing below.
make
and ensure the site still buildsChecklist
qa.languageforge.org testing
Reviewers: add/replace your name below and check the box to sign-off/attest the feature works as expected on qa.languageforge.org