Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update typescript to 4.6 #1422

Merged
merged 4 commits into from
Jun 9, 2022
Merged

Update typescript to 4.6 #1422

merged 4 commits into from
Jun 9, 2022

Conversation

rmunn
Copy link
Collaborator

@rmunn rmunn commented Jun 9, 2022

Description

Update Typescript to 4.6 so it matches the Typescript version used in Playwright and Svelte, to avoid future problems.

Fixes #1325.

Type of Change

Only keep lines below that describe this change, then delete the rest.

  • Bug fix (non-breaking change which fixes an issue)

Testing on your branch

Please describe how to test and/or verify your changes. Provide instructions so we can reproduce. Please also provide relevant test data as necessary. These instructions will be used for QA testing below.

  • Run make and ensure the site still builds

Checklist

  • I have performed a self-review of my own code
  • I have reviewed the title/description of this PR which will be used as the squashed PR commit message
  • I have commented my code, particularly in hard-to-understand areas
  • I have added tests that prove my fix is effective or that my feature works

qa.languageforge.org testing

Reviewers: add/replace your name below and check the box to sign-off/attest the feature works as expected on qa.languageforge.org

  • Reviewer1 (YYYY-MM-DD HH:MM)
  • Reviewer2 (YYYY-MM-DD HH:MM)

rmunn added 4 commits June 9, 2022 16:04
The ts-loader package is actuvely maintained, while
awesome-typescript-loader hasn't been updated in 4 years.
New Typescript version is stricter about uninitialized properties, and
produced two compiler errors with our current code. I fixed them in two
different ways, based on what appeared to be the intent of the code in
each case.
@rmunn
Copy link
Collaborator Author

rmunn commented Jun 9, 2022

There's also a change to the Dockerfile for next-app in here, because while buildx appears to build that file as-is just fine, my Docker installation (which isn't using buildx) complains about the missing / in a COPY command, and says "Since that's a directory, you must include a trailing slash". So I added it in this PR because it's a very small change and likely won't cause any merge conflicts. I can remove it if it matters.

@github-actions
Copy link

github-actions bot commented Jun 9, 2022

Unit Test Results

373 tests   373 ✔️  14s ⏱️
    1 suites      0 💤
    1 files        0

Results for commit fb603a6.

@megahirt
Copy link
Collaborator

megahirt commented Jun 9, 2022

There's also a change to the Dockerfile for next-app in here, because while buildx appears to build that file as-is just fine, my Docker installation (which isn't using buildx) complains about the missing / in a COPY command, and says "Since that's a directory, you must include a trailing slash". So I added it in this PR because it's a very small change and likely won't cause any merge conflicts. I can remove it if it matters.

I think it's fine to fix it up.

For the record, everyone should have export DOCKER_BUILDKIT=1 in their environment. This only affects Linux systems that installed Docker as a package. The "Docker for Windows/Mac/Linux" installation does this automatically.

Copy link
Collaborator

@megahirt megahirt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM this is a welcome upgrade, Robin!

@rmunn rmunn merged commit 46baa23 into develop Jun 9, 2022
@rmunn rmunn deleted the chore/update-typescript-to-4.6 branch June 9, 2022 23:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update Typescript to 4.x (latest if possible)
2 participants