-
-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Semantic domains tests #1487
Merged
Merged
Semantic domains tests #1487
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JeanneSon
commented
Sep 27, 2022
alex-larkin
added
the
engineering
Tasks which do not directly relate to a user-facing feature or fix
label
Sep 29, 2022
longrunningprocess
suggested changes
Sep 29, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
that was a lot, nice work!
Two things:
- It would be good to rebase
develop
and make sure the tests are still good before merging, I suspect they would be. - I'm seeing a consistent test failure locally even though they don't seem to be failing when run as part of this PR... not sure if this is a problem or not but it might be good to have one more person run these locally to be sure.
1 failed
[chromium] › semantic-domains.spec.ts:46:3 › Lexicon E2E Semantic Domains Lazy Load › Can change Project default language to Thai & back and forth
Error: expect(received).toHaveText(expected)
- Expected string - 1
+ Received string + 3
- ภาษาไทย
+
+
+ English
Call log:
- expect.toHaveText with timeout 5000ms
- waiting for selector "#languageDropdownButton"
- selector resolved to <a href="" aria-haspopup="true" aria-expanded="fals…>…</a>
- unexpected value "
English"
- selector resolved to <a href="" aria-haspopup="true" aria-expanded="fals…>…</a>
- unexpected value "
English"
- selector resolved to <a href="" aria-haspopup="true" aria-expanded="fals…>…</a>
- unexpected value "
English"
- selector resolved to <a href="" aria-haspopup="true" aria-expanded="fals…>…</a>
- unexpected value "
English"
- selector resolved to <a href="" aria-haspopup="true" aria-expanded="fals…>…</a>
- unexpected value "
English"
- selector resolved to <a href="" aria-haspopup="true" aria-expanded="fals…>…</a>
- unexpected value "
English"
- selector resolved to <a href="" aria-haspopup="true" aria-expanded="fals…>…</a>
- unexpected value "
English"
- selector resolved to <a href="" aria-haspopup="true" aria-expanded="fals…>…</a>
- unexpected value "
English"
59 | await projectSettingsPage.projectTab.saveButton.click();
60 | await expectOptionSelectedInSelectElement(projectSettingsPage.projectTab.defaultInterfaceLanguageInput, 'ภาษาไทย');
> 61 | await expect(pageHeader.languageDropdownButton).toHaveText('ภาษาไทย');
| ^
62 |
63 | // should be using Thai semantic domain
64 | await editorPage.goto();
megahirt
force-pushed
the
chore/semanticDomainsTests
branch
from
September 30, 2022 08:30
cf575f1
to
665eb04
Compare
All tests pass after rebasing... |
As in the other cases when another default interface language is chosen, timeouts make now sure the page has more time to be ready.
longrunningprocess
approved these changes
Sep 30, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
engineering
Tasks which do not directly relate to a user-facing feature or fix
testing
Pertaining to unit or e2e testing
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The following test has been converted to playwright
✓ should be using English Semantic Domain for manager
The other tests had to be combined to one large tests called Can change Project default language to Thai & back and forth as they were all dependent on each other
✓ can change Project default language to Thai
✓ should be using Thai Semantic Domain
✓ can change Project default language back to English
✓ should be using English Semantic Domain
✓ can change Project default language back to Thai
✓ should be using Thai Semantic Domain after refresh
✓ can change user interface language
✓ should still have Thai for Project default language
✓ should be using English Semantic Domain
✓ should be using English Semantic Domain after refresh
✓ should still have Thai for Project default language
✓ can change user interface language to English
✓ can change Project default language to match interface language twice
✓ can change user interface language to back English
For the conversion, a helper function was needed which allows the developer to check the selected option of
a select dropdown. It is located in the file playwright-helpers.ts.
Type of Change
Checklist