-
-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Set up to run LexBox alongside LF in dev mode #1790
Conversation
Language Forge port changed to port 8080 so that port 80 can belong to local LexBox.
Unit Test Results362 tests 362 ✅ 13s ⏱️ Results for commit bbd54f1. |
Tested on my machine and it works. Could clone a large project with embedded audio files, and verified that all entries were present and the audio files played correctly. Also tested with #1789 merged into this PR, which also cloned the same project correctly. |
I can't access 8080 consistently. I have no idea why. After every But it did hit my local lexbox when it worked. That was cool. |
I actually had the same problem yesterday, tried 8081 and it didn't work, tried 8083 and it worked. Have not yet determined why: nothing was listening on port 8080 (I checked), so there wasn't a port conflict. But somehow, Docker Compose just would not hook up port 8080, and didn't give me an error message explaining why. |
More weirdness from Docker Compose. I'm not seeing any At the moment, I'm inclined to hold off on merging this PR, because the port weirdness makes it nearly unmanageable to do LF development: every time you run |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These changes look good. I know that we're dealing with port mapping weirdness but honestly I don't think it's due to these changes but rather to buggy docker compose behavior that exists regardless. I'd rather get this merged and continue figuring out how to make the two repos working together. Merging is a step in the right direction.
One thing I'm sure about is whether SvelteKit or something Svelte related in LF was running on 8080 already. I couldn't find any reference in our code to 8080 but it's possible it's the default for something that is not spelled out in code.
There are no other references to port 8080, and Svelte-Kit's default port is 5173 or 4173 depending on if you're running the dev server (default port 5173) or the preview server (default port 4173). So using port 8080 won't conflict with anything internal. It might possibly conflict with the defaults of some other tools, and if it does, we can easily accept a new PR to change it to some arbitrarily-chosen port number. But I think sticking with 8080 will be fine. |
Language Forge port changed to port 8080 so that port 80 can belong to local LexBox.
Fixes sillsdev/languageforge-lexbox#708
Description
Add appropriate environment variables to docker-compose.yml so that Language Forge can be run alongside a locally-installed copy of LexBox.
Screenshots
Checklist
Testing
To run:
task up
make
To verify:
http://localhost:8080
to run Language Forgemanager
and passwordpass
docker logs -f lfmerge
to watch the clone process